Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels should toggle their button #1628

Closed
HeyMyian opened this issue Nov 27, 2023 · 3 comments · Fixed by #1638
Closed

Labels should toggle their button #1628

HeyMyian opened this issue Nov 27, 2023 · 3 comments · Fixed by #1638
Labels
enhancement Request: New feature or improvement next release Note: Features planned for next release user interface Component: General user interface
Milestone

Comments

@HeyMyian
Copy link
Contributor

Issue title might be misnamed, sorry. I'm specifically talking about the "Comment" and "Synopsis" toggles in the Document Viewer:

Screenshot_2023-11-27_04-21-24

They toggle only when clicked on the tiny icon. The label of the toggle could (should?) function as an extension of the icon. See HTML label tag, which this reminds me of: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label

@HeyMyian HeyMyian added the enhancement Request: New feature or improvement label Nov 27, 2023
@vkbo vkbo added the user interface Component: General user interface label Nov 27, 2023
@vkbo
Copy link
Owner

vkbo commented Nov 27, 2023

This is a button though, and not an icon. The alternative is to make the whole thing a button, or change it to a switch. HTML behaviour is not relevant. On the UI, clicking labels generally don't activate the function.

@tmarplatt
Copy link
Contributor

I believe this to be part of a larger UX issue.

I don't know if they scale with system settings, but buttons in novelWriter are small by default and therefore hard to click. The user wants the GUI to be as navigable as possible, else their creative focus gets interrupted. Clickable labels are one step towards that, even if the user has no accessibility requirements/configuration set.

@vkbo
Copy link
Owner

vkbo commented Dec 3, 2023

Clickable labels are a feature of checkboxes and radio buttons, not tool buttons (checkable or not) in Qt. As I said, I can convert these to buttons with text.

Not sure what you mean by "larger UX issue" If you mean the project tree tool buttons and the new hideable toolbar in the editor, then yes, they are proportional to the text settings. You increase them automatically if you increase the GUI font size. A lot of the UI is modelled after VSCode UI.

@vkbo vkbo added this to the Release 2.2 milestone Dec 3, 2023
@vkbo vkbo added the next release Note: Features planned for next release label Dec 3, 2023
@vkbo vkbo closed this as completed in #1638 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request: New feature or improvement next release Note: Features planned for next release user interface Component: General user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants