Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme updates #1475

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Theme updates #1475

merged 5 commits into from
Jul 19, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jul 19, 2023 •
edited
Loading

Summary:

This PR:

  • Adds a proper light theme, but leaves the default theme as whatever Qt chooses.
  • Selects default icon theme based on the lightness of the window colour.
  • Adds the help text colour to the theme config file and sets it for the existing themes.

Related Issue(s):

Closes #1472
Closes #1473

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.1 Beta 1 milestone Jul 19, 2023
This was linked to issues Jul 19, 2023
Make additional theme colours customisable #1472
Closed
Define the light theme #1473
Closed
@vkbo vkbo merged commit 3af60b4 into dev Jul 19, 2023
@vkbo vkbo deleted the theme_update branch July 19, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.1 Beta 1
Development

Successfully merging this pull request may close these issues.

Define the light theme Make additional theme colours customisable
1 participant
@vkbo