Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar cleanup and minor fixes #1520

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Sidebar cleanup and minor fixes #1520

merged 5 commits into from
Sep 5, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Sep 5, 2023

Summary:

This PR:

  • Fixes a few minor issues in the code.
  • Changes the spell checker to only spell check words with only letters in them (Python str.isalpha()).
  • Removes the text labels in the side bar and converts it to a layout box with tool buttons. The tool buttons have the same style sheets as other tool buttons in the app.
  • Takes control over the popup location of the menu on the Settings button. It will now always pop up to the right of the button, growing upwards from the bottom of the button.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.2 Beta 1 milestone Sep 5, 2023
@vkbo vkbo merged commit 8275963 into dev Sep 5, 2023
9 checks passed
@vkbo vkbo deleted the fixes branch September 5, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant