Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n issues #1565

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Fix i18n issues #1565

merged 3 commits into from
Nov 2, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 2, 2023

Summary:

This PR solves two issues:

  • All strings defined in the build settings core class were sent to the GUI untranslated even when translations exist.
  • When no GUI language is set, novelWriter defaults to the system locale. However, if that is not available in novelWriter, the Preferences dialog would just leave the dropbox on the first option, which is currently "Deutch". The config class now only defaults to system locale if there is a translation file for it available. Otherwise it defaults to "British English". The Preferences will also default to "British English" if the language setting in config is invalid or has become unavailable.

Related Issue(s):

Closes #1563
Closes #1564

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.1.1 milestone Nov 2, 2023
@vkbo vkbo merged commit f9df78a into main Nov 2, 2023
9 checks passed
@vkbo vkbo deleted the fixes branch November 2, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppImage: default GUI language appears as German (Deutsch) Most recent translations missing in 2.1
1 participant