Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix viewer navigation #1568

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Fix viewer navigation #1568

merged 3 commits into from
Nov 3, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 3, 2023 •
edited
Loading

Summary:

The anchor tags were still generated based on line numbers instead of heading number, so following a link to a heading didn't work in the viewer.

Related Issue(s):

Closes #1566

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.1.1 milestone Nov 3, 2023
@vkbo vkbo changed the title Fix anchor tags in html output (#1566) Fix viewer navigation Nov 3, 2023
@vkbo vkbo merged commit 0413684 into main Nov 3, 2023
9 checks passed
@vkbo vkbo deleted the html_anchors branch November 3, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.1.1
Development

Successfully merging this pull request may close these issues.

Following a reference doesn't scroll the viewer
1 participant
@vkbo