Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annotations and add deleteLater to several temporary objects #1629

Merged
merged 10 commits into from
Nov 28, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 27, 2023

Summary:

This PR cleans up some annotations here and there, and adds the deleteLater call to a number of objects. In particular, the editor context menu needs this as each instance of the menu seems to remain in memory. All dialogs and tools have been redesigned to clean up after themselves where possible.

To test the memory cleanup, a new flag --meminfo has been added to the command line that will display momory information on the status bar when set.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.2 milestone Nov 27, 2023
@vkbo vkbo merged commit d291995 into dev Nov 28, 2023
9 checks passed
@vkbo vkbo deleted the dialog_and_menu_handling branch November 28, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant