Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements functionality of various dialogs #1681

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Improvements functionality of various dialogs #1681

merged 7 commits into from
Feb 1, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Feb 1, 2024

Summary:

This PR fixes a bunch of minor details on the Welcome dialog:

  • The opacity of the highlight colour for a selected item has been reduced.
  • When a project is removed from the list, the first item is selected automatically.
  • When a project is requested opened, the dialog hides before the open project signal is emitted, so that it looks like the welcome dialog closes before the project is opened. In reality, it closes after the signal. Previously, when it stayed visible, any dialogs that popped up during the closing of the previous project and opening of the next would open on top of the welcome dialog, which was a bit confusing.
  • Adds a modified version of QComboBox, QSpinBox, and QDoubleSpinBox where the mouse scroll wheel is only captured by the widget when the widget has focus. This prevents accidentally changing the value when scrolling the page. The new widgets are used on the Welcome dialog New project form, and also replaced in Preferences, Project Setting and Manuscript Build Settings.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.3 Beta 1 milestone Feb 1, 2024
@vkbo vkbo changed the title Make some improvements to the Welcome dialog Improvements functionality of various dialogs Feb 1, 2024
@vkbo vkbo merged commit 8af720c into dev Feb 1, 2024
9 checks passed
@vkbo vkbo deleted the welcome_update branch February 1, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant