Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter helper for file extensions filters #1693

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Add formatter helper for file extensions filters #1693

merged 2 commits into from
Feb 11, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Feb 11, 2024

Summary:

This PR adds a helper function for building file extension filters for file dialogs. Aside from not having to generated this special format in multiple places in the code, it also combines the translation strings for the ones used multiple places into a single lookup dictionary, preventing duplicate translation entries.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.3 Beta 1 milestone Feb 11, 2024
@vkbo vkbo merged commit fb92c6c into dev Feb 11, 2024
9 checks passed
@vkbo vkbo deleted the file_filters branch February 11, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant