Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite checking for updates #1696

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Rewrite checking for updates #1696

merged 6 commits into from
Feb 14, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Feb 14, 2024

Summary:

This PR drops the old "Check for Updates" dialog box in favour of a widget that can be included in other dialogs. The widget has one line of current version information and a link to the Releases page of the website, and a second line that by default says "Latest Version: Check Now" where clicking "Check Now" will retrieve this information from the GitHub API. The API call is rate limited to 60 calls per hour, which should be fine since the widget will only let you click the link once.

This new version info widget is added to the Welcome dialog and the About dialog.

Screencast.from.2024-02-14.19-01-40.mp4

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.3 Beta 1 milestone Feb 14, 2024
@vkbo vkbo merged commit 1a635f6 into dev Feb 14, 2024
9 checks passed
@vkbo vkbo deleted the update_check branch February 14, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant