Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deleteLater calls from Manuscript tools #1905

Merged
merged 1 commit into from
May 30, 2024
Merged

Remove deleteLater calls from Manuscript tools #1905

merged 1 commit into from
May 30, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 30, 2024 •
edited
Loading

Summary:

This PR backports the critical part of the deleteLater fix from #1899.

Related Issue(s):

Closes #1903

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.4.4 milestone May 30, 2024
@vkbo vkbo linked an issue May 30, 2024 that may be closed by this pull request
Backport memory cleanup from 2.5 to 2.4 #1903
Closed
@vkbo vkbo merged commit a11a013 into release May 30, 2024
8 checks passed
@vkbo vkbo deleted the backport_deletelater_fix branch May 30, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.4.4
Development

Successfully merging this pull request may close these issues.

Backport memory cleanup from 2.5 to 2.4
1 participant
@vkbo