Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR changes the dialog parent class to overload the virtual
reject()
slot and add a call toclose()
to it. This makes this a usable slot for all dialogs as this is the behaviour we want in novelWriter. It also solves an issue whereclose()
is used as a slot, even if it isn't a valid slot.This also fixes a bug introduced with the
NDialog
class in the 2.5 release cycle.Related Issue(s):
Closes #1915
Reviewer's Checklist: