Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dialog closing #1918

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Refactor dialog closing #1918

merged 7 commits into from
Jun 10, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jun 9, 2024

Summary:

This PR changes the dialog parent class to overload the virtual reject() slot and add a call to close() to it. This makes this a usable slot for all dialogs as this is the behaviour we want in novelWriter. It also solves an issue where close() is used as a slot, even if it isn't a valid slot.

This also fixes a bug introduced with the NDialog class in the 2.5 release cycle.

Related Issue(s):

Closes #1915

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 RC 1 milestone Jun 9, 2024
@vkbo vkbo merged commit 9bcb247 into main Jun 10, 2024
8 checks passed
@vkbo vkbo deleted the dialog_closing branch June 10, 2024 11:48
@vkbo vkbo changed the title Refactir dialog closing Refactor dialog closing Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit label save on enter
1 participant