Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more characters to be used in file names #1922

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jun 11, 2024

Summary:

File and folder names are currently restricted to mostly alphanumeric characters, plus a few more. This PR changes it so that only non-printable characters are disallowed, plus a handful of other characters primarily disallowed by Windows.

Related Issue(s):

Closes #1917

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 RC 1 milestone Jun 11, 2024
@vkbo vkbo merged commit e7c0d59 into main Jun 11, 2024
8 checks passed
@vkbo vkbo deleted the improve_filnamesafe branch June 11, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project folder name should be less restrictive
1 participant