Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure editor content is saved before using it #1923

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jun 11, 2024

Summary:

This PR:

  • Adds a method to the shared object that can be called when it is important that the content of the document editor is saved before it is used to perform an action.
  • Use this method in the Manuscript tool (replaces the old implementation).
  • Adds this to the "Rename to Heading" context menu handler in the project tree.

Related Issue(s):

Closes #1914

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.4.4 milestone Jun 11, 2024
@vkbo vkbo linked an issue Jun 11, 2024 that may be closed by this pull request
@vkbo vkbo merged commit 195a7e3 into release Jun 11, 2024
9 checks passed
@vkbo vkbo deleted the ensure_editor_saved branch June 11, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project View/Rename to Heading does not reflect last change
1 participant