Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rehighlight tags on note creation #1938

Merged
merged 3 commits into from
Jun 16, 2024
Merged

Rehighlight tags on note creation #1938

merged 3 commits into from
Jun 16, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jun 16, 2024

Summary:

This PR adds a new slot in the document editor to listen to changes in tags from the index and updates the syntax highlighting on all meta data lines. This ensures that when a new note is created from an unknown reference in the editor, the highlighting changes afterwards.

Related Issue(s):

Closes #1916

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 RC 1 milestone Jun 16, 2024
@vkbo vkbo merged commit cb3a24b into main Jun 16, 2024
8 checks passed
@vkbo vkbo deleted the editor_rehighlight_tags branch June 16, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh syntax highlighting on note creation
1 participant