Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview indent and status bar LEDs #1962

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Fix preview indent and status bar LEDs #1962

merged 4 commits into from
Jul 5, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jul 5, 2024

Summary:

This PR fixes the em unit calculation in the document preview class. It was using font height instead of font ascent as the base unit. This PR also fixes the High DPI scaling of the Status Bar LEDs.

Related Issue(s):

Closes #1961

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5 milestone Jul 5, 2024
@vkbo vkbo changed the title Fix preview indent Fix preview indent and status bar LEDs Jul 5, 2024
@vkbo vkbo merged commit dd03c19 into main Jul 5, 2024
8 checks passed
@vkbo vkbo deleted the fix_preview_em branch July 5, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Tool Preview Indent
1 participant