Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock project only after successful open #1978

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jul 14, 2024

Summary:

This PR removes the automatic lock file writing during project storage initiation and until after project open is completed.

Related Issue(s):

Closes #1977

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5.1 milestone Jul 14, 2024
@vkbo vkbo merged commit 7140788 into release Jul 14, 2024
8 checks passed
@vkbo vkbo deleted the clear_session_on_not_open branch July 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock file in the project folder is staying behind when it should be removed.
1 participant