Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure free form text boxes in Preferences are safe #1986

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jul 21, 2024

Summary:

This PR adds a new function that checks free form text box settings in Preferences, and adds constraints to others.

  • Narrator break, which can only be one character, has white space stripped,
  • Dialog symbol, which can only be one character, has white space stripped.
  • Pad before and after symbol box content is now processed so that all white spaces are stripped, and all characters listed are unique. They are also sorted, because the filter uses set, which may return different order on each call.

Related Issue(s):

Closes #1985

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5.1 milestone Jul 21, 2024
@vkbo vkbo linked an issue Jul 21, 2024 that may be closed by this pull request
@vkbo vkbo merged commit 826e805 into release Jul 21, 2024
8 checks passed
@vkbo vkbo deleted the check_free_form_settings branch July 21, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out spaces from various free form preferences boxes
1 participant