Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tag navigation #1987

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Improve tag navigation #1987

merged 2 commits into from
Jul 21, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jul 21, 2024 •
edited
Loading

Summary:

This PR fixes an issue where clicking to edit a tag from the reference panel doesn't scroll to the tag position in the text.

Related Issue(s):

Closes #1983

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.5.1 milestone Jul 21, 2024
@vkbo vkbo linked an issue Jul 21, 2024 that may be closed by this pull request
Clicking the edit button for a tag in the references panel doesn't scroll #1983
Closed
@vkbo vkbo merged commit 57fced2 into release Jul 21, 2024
8 checks passed
@vkbo vkbo deleted the tag_navigation branch July 21, 2024 17:50
@awqk awqk mentioned this pull request Jul 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.5.1
Development

Successfully merging this pull request may close these issues.

Clicking the edit button for a tag in the references panel doesn't scroll
1 participant
@vkbo