Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dialogue highlighting after feedback #2082

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Improve dialogue highlighting after feedback #2082

merged 2 commits into from
Nov 5, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 4, 2024

Summary:

This PR makes a couple of minor changes to the dialogue highlighting feature, and adds auto-replacement of horizontal bar with em-dash in the tokenizer.

Related Issue(s):

Related #1773

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6 Beta 1 milestone Nov 4, 2024
@vkbo vkbo merged commit 04036ef into main Nov 5, 2024
9 checks passed
@vkbo vkbo deleted the dialogue_tweaks branch November 5, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant