Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @ on AZERTY on wasm #181

Closed

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented May 22, 2023

Follow up on #149 ; I'm building on wasm and realized my fix is not sufficient, I can't input @ on wasm :'(.

In #149 we did a minimal change by checking only windows, but I think we're overly conservative, I'd like to discuss why this condition is needed, and make proper tests about it to validate its usefulness.

@Vrixyz
Copy link
Contributor Author

Vrixyz commented May 22, 2023

support for ctrl-A was mentionned, but I can attest this PR does not break it. (it's ctrl-Q on my keyboard though, but same behaviour as current live web showcase)

Copy link

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about ALT behavior? Shouldn't those keys also be skipped, like in the original implementation?

@Vrixyz
Copy link
Contributor Author

Vrixyz commented May 23, 2023

I think we actually don't want to prevent ALT, this PR enables me to input weird characters with altcodes (alt + keys): like the alt + (1;3;0) inputs é (https://www.alt-codes.net/)

@vladbat00
Copy link
Owner

vladbat00 commented Jul 10, 2023

I'm afraid this breaks the Cmd+A functionality on MacOS: selecting the text works, but it also inserts the "A" character afterwards.

@Vrixyz
Copy link
Contributor Author

Vrixyz commented Jan 29, 2024

I'm afraid this breaks the Cmd+A functionality on MacOS: selecting the text works, but it also inserts the "A" character afterwards.

Indeed, I think a better fix would be to check for the user agent on web ; and keep this "ctrl+alt" special case gated for windows only.

An implementation of checking for user agent is available there: https://github.com/mvlabat/bevy_egui/pull/178/files#diff-420f4e08a25299e0e1fb09f4757e1d5d027a2278f37030c09ab9c06786cfa52eR85-R99

@Vrixyz
Copy link
Contributor Author

Vrixyz commented Feb 6, 2024

I'm closing this and will work on previous comment

@Vrixyz Vrixyz closed this Feb 6, 2024
@Vrixyz Vrixyz mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants