feat: warn when no queries to run

Closes #8
vladfaust · Oct 15, 2018 · f315a8e · f315a8e
1 parent 9d56ddf
commit f315a8e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/spec/migrate/migrator_with_errors_spec.cr b/spec/migrate/migrator_with_errors_spec.cr
@@ -15,7 +15,7 @@ describe "Migrate::Migrator with errors" do
 
   migrator = Migrate::Migrator.new(
     db,
-    nil,
+    Logger.new(STDOUT).tap(&.level = Logger::DEBUG),
     File.join("spec", "migrations_with_errors")
   )
 

diff --git a/spec/migrations_with_errors/1.sql b/spec/migrations_with_errors/1.sql
@@ -1,11 +1,3 @@
 -- +migrate up
-CREATE TABLE foo (
-  id      SERIAL PRIMARY KEY,
-  content TEXT NOT NULL
-);
-
--- Indexes
-CREATE UNIQUE INDEX foo_content_index ON foo (content);
-
 -- +migrate down
 -- +migrate error Could not migrate down from version 1
diff --git a/src/migrate/migrator.cr b/src/migrate/migrator.cr
@@ -154,9 +154,13 @@ module Migrate
         end
 
         @db.transaction do |tx|
-          queries.not_nil!.each do |query|
-            @logger.try &.debug(query)
-            tx.connection.exec(query)
+          if queries.not_nil!.empty?
+            @logger.try &.warn("No queries to run in migration file with version #{version}, applying anyway")
+          else
+            queries.not_nil!.each do |query|
+              @logger.try &.debug(query)
+              tx.connection.exec(query)
+            end
           end
 
           @logger.try &.debug(update_version_query(version))