Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates on ci #55

Merged
merged 2 commits into from
Nov 5, 2024
Merged

updates on ci #55

merged 2 commits into from
Nov 5, 2024

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Nov 4, 2024

  • use best practices for github actions
  • split the job for have more clarity: ci (build/test) and golangci-lint for lint
  • add windows tests
  • test with go 1.22 and 1.23

@cpanato
Copy link
Contributor Author

cpanato commented Nov 4, 2024

cc @vladimirvivien

@vladimirvivien
Copy link
Owner

@cpanato thank you very much for this.

vladimirvivien
vladimirvivien approved these changes Nov 4, 2024
View reviewed changes
Copy link
Owner

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirvivien
Copy link
Owner

@cpanato windows not playing nice.

@cpanato
updates on ci
3e648e1 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Contributor Author

cpanato commented Nov 5, 2024

@vladimirvivien fixed

@vladimirvivien
Copy link
Owner

@cpanato LoL you are basically forcing Windows support.
This is good as it's been on the roadmap for the longest.
I will create/push some changes with Windows support in mind, then come back to this to make it work.

@cpanato
comment out windows tests
e590bda 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Contributor Author

cpanato commented Nov 5, 2024

@vladimirvivien ptal

@cpanato
Copy link
Contributor Author

cpanato commented Nov 5, 2024

is it flaky?

@vladimirvivien vladimirvivien merged commit 1c64441 into vladimirvivien:main Nov 5, 2024
3 checks passed
@cpanato cpanato deleted the ci branch November 6, 2024 11:07
@vladimirvivien
Copy link
Owner

vladimirvivien commented Nov 6, 2024 •
edited
Loading

@cpanato I thought I fixed the flake.
I will take another look this weekend.
Unable to replicate unless it's in CI.
But I will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirvivien vladimirvivien vladimirvivien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpanato @vladimirvivien