-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow option to manually enable and load email accounts #316
Comments
The requested feature is already there, enabled since v3.1.0. Also, I guess you might want to explore the persistent session feature too. |
No. I mean these options.
|
Won't fix then. |
But what's the reason for consider to ignore it? |
A balance of demand / increased complexity of code&maintainability&UX / my capacity / etc. |
However i think this might be a useful feature also essential for multiple accounts own users. Someone may able to help if this keep opened or you can implement when less issues in repository. |
It's not only about implementing some new feature but also about supporting it in the future since in general the maintenance burden gets increased with code base growing. So even if someone will be willing to implement the requested feature I won't be accepting it in this protect at this time which means that should be maintained as a fork by the feature author. |
Late visit :) Can't you just add only a enable/disable option?, discarding everything else mentioned by @kizunaH (it seems new facilities and UI enhancements she suggested for electronmail) so It'll not expand the codebase as you make sounds. (The simple goal is to ensure and prevent particular mailboxes get network access. that's what we expect as multiple account users. When enable then it can follow the normal login procedure to load the mailbox or it can be either persistent session according configuration made when add mailbox or simple task like break the domain to box or something like that when disable it. Anyway as easy for you with minimum code lines) Both are electron based apps and you can minimize what've done to implement that option in rambox |
Adding only the disabling toggle near to the account is not a big change indeed. |
The feature by the way works nicely with the persistent session feature. Means you can deactivate and activate the account back having the login form skipped. The app doesn't drop the saved session if any but only disables the account loading/rendering. |
If someone wants to try the WIP build with the enabled feature, it's uploaded here. |
* so the cursor style is consistent across the app (no "pointer" cursor applied to the rest toggles)
Nice to see this feature quick. :) |
* so the cursor style is consistent across the app (no "pointer" cursor applied to the rest toggles)
* the app should not fire ACCOUNTS_ACTIONS.PatchProgress action for disabled accounts
* so the cursor style is consistent across the app (no "pointer" cursor applied to the rest toggles)
* ACCOUNTS_ACTIONS.PatchProgress action should not be fired for disabled accounts
Updated WIP build uploaded here (fixed "Failed to resolve account" error occuring). |
Current way atleast primary mailbox automatically load and login when open electronmail and it seems rest of them get loaded as well. Logout from certain mailboxes also not possible. Can you enhance settings page for,
(This feature for already logon accounts after launched the app and it doesn't remember that for next launch)
(When user click disable then the account should logout first then disable it in UI)
Example: https://github.com/ramboxapp/community-edition
It has option(area) in right side for enable or disable services but i'm not prefer electronmail implement the same and separate page because i dont like people abuse the protonmail and use accounts for bad purposes or bother, harm people.
The text was updated successfully, but these errors were encountered: