Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ProtonCalendar Desktop notifications working? #328

Closed
SchrodingerZhu opened this issue Sep 18, 2020 · 10 comments
Closed

Is ProtonCalendar Desktop notifications working? #328

SchrodingerZhu opened this issue Sep 18, 2020 · 10 comments
Labels

Comments

@SchrodingerZhu
Copy link

I get no popup on KDE plasma.

vladimiry added a commit that referenced this issue Sep 18, 2020
* so the following projects should not be affected: "proton-mail-settings", "proton-contacts", "proton-calendar"
@vladimiry
Copy link
Owner

vladimiry commented Sep 18, 2020

The cfa3b00 change should make the Notification triggered by @ProtonMail on the Calendar page work. The change is going to land in the next release.

But it's not really helpful since:

  • v4-beta designed by @ProtonMail in the way so you have to keep the Calendar page open to get the desktop notifications/alarms.
  • When you click the button on Notification alert nothing will happen since the app currently doesn't implement the tight integration with the Calendar page. Such integration is supposed to happen in Sync Calendar events to the local encrypted database for offline access #229. Besides I believe it's technically possible to make the desktop notification work regardless of the page being opened so you get the alarm displayed even if you have the WebClient/Mails page opened.

@vladimiry vladimiry added the bug label Sep 18, 2020
vladimiry added a commit that referenced this issue Sep 19, 2020
* so the following projects should not be affected: "proton-mail-settings", "proton-contacts", "proton-calendar"
vladimiry added a commit that referenced this issue Sep 19, 2020
* so the following projects should not be affected: "proton-mail-settings", "proton-contacts", "proton-calendar"
vladimiry added a commit that referenced this issue Sep 25, 2020
* so the following projects should not be affected: "proton-mail-settings", "proton-contacts", "proton-calendar"
@vladimiry
Copy link
Owner

The work-in-progress v4.9.0 version with the included fix is uploaded here. For everyone running this build I highly recommend enabling the opt-in Block non "API entry point"-based network requests option for all accounts (see how to enable it on the screenshot in #312 (comment))

@Tommy3621
Copy link

The work-in-progress v4.9.0 version with the included fix is uploaded here. For everyone running this build I highly recommend enabling the opt-in Block non "API entry point"-based network requests option for all accounts (see how to enable it on the screenshot in #312 (comment))

I did update and still can't get desktop notifications from the calendar

@vladimiry
Copy link
Owner

vladimiry commented Oct 29, 2020

  • Does it work in browser?
  • What are the issue reproducing steps?

I just have created the event and got the notification displayed (having Calendar page opened, not the Mails page). Also clicked the "Send test notification" button in Calendar Settings section and it worked too.

@Tommy3621
Copy link

Tommy3621 commented Oct 29, 2020

* Does it work in browser?

* What are the issue reproducing steps?

I just have created the event and got the notification displayed (having Calendar page opened, not the Mails page). Also clicked the "Send test notification" button in Calendar Settings section and it worked too.

It does work in the browser version, yes.

So the notification option in the ElectronMail app was "enabled" from the beginning iirc while I had to enable it in browser first. Clicking "send test notification" doesn't do anything, neither does creating an event for like ~5min in the future. The timer for sotifications within the event-settings is set to "1min before"

@vladimiry
Copy link
Owner

What is the commit/hash value you see in the app about window (near to version number)?

@Tommy3621
Copy link

Tommy3621 commented Oct 29, 2020

What is the commit/hash value you see in the app about window (near to version number)?

ElectronMail v4.9.0 f030818

or this?

"Electron: 10.1.5
Chromium: 85.0.4183.121
Node: 12.16.3
V8: 8.5.210.26-electron.0"

@vladimiry
Copy link
Owner

vladimiry commented Oct 29, 2020

It's f030818 value, thanks. It worked for me for the same app build, so the issue appears to be system-dependent and at the moment I have no guess what I could do to make it work for you. But I'm considering enabling Calendar desktop notifications/alarms regardless of the opened page (see #229 (comment) for details) and maybe then it will work for you since that will be a custom notification triggered not by proton but by app.

@Tommy3621
Copy link

So, found out what the issue was after noticing that also the regular windows calendar doesn't give me any notifications. And of course it's a really dumb reason why.

There's this "do not disturb" function in Win10 that I apparently had activated without knowing. It doesn't show in the windows-notifications-settings, that's why I didn't see it at first

@vladimiry
Copy link
Owner

Thanks for the update. So if I get it right the shared before f030818 build is functional for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants