go 1.23 version bump (#100)

vladopajic · Aug 28, 2024 · e3daf9d · e3daf9d
1 parent af428bc
commit e3daf9d
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -14,6 +14,6 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.59.1
+          version: v1.60.3
       - name: go mod tidy check
         uses: katexochen/go-tidy-check@v2
diff --git a/.golangci.yml b/.golangci.yml
@@ -10,6 +10,7 @@ linters:
     - containedctx
     - contextcheck
     - cyclop
+    - copyloopvar
     - decorder
     - dogsled
     - dupl
@@ -21,7 +22,6 @@ linters:
     - errname
     - errorlint
     - exhaustive
-    - exportloopref
     - forbidigo
     - forcetypeassert
     - funlen

diff --git a/Dockerfile b/Dockerfile
@@ -1,5 +1,5 @@
 # GO_VERSION: go version should match version in go.mod file
-FROM golang:1.22 as builder
+FROM golang:1.23 as builder
 WORKDIR /workspace
 
 COPY go.mod go.mod

diff --git a/Makefile b/Makefile
@@ -1,7 +1,7 @@
 GO ?= go
 GOBIN ?= $$($(GO) env GOPATH)/bin
 GOLANGCI_LINT ?= $(GOBIN)/golangci-lint
-GOLANGCI_LINT_VERSION ?= v1.59.1
+GOLANGCI_LINT_VERSION ?= v1.60.3
 
 # Code tidy
 .PHONY: tidy

diff --git a/go.mod b/go.mod
@@ -1,7 +1,7 @@
 module github.com/vladopajic/go-test-coverage/v2
 
 // GO_VERSION: when changing go version update version in other places
-go 1.22
+go 1.23
 
 require (
 	github.com/alexflint/go-arg v1.4.3

diff --git a/pkg/testcoverage/helpers_test.go b/pkg/testcoverage/helpers_test.go
@@ -47,9 +47,9 @@ func randStats(localPrefix string, minc, maxc int) []coverage.Stats {
 	}
 }
 
-func makeCoverageGenFn(min, max int) func() (total, covered int64) {
+func makeCoverageGenFn(minc, maxc int) func() (total, covered int64) {
 	return func() (int64, int64) {
-		tc := rand.Intn(max-min+1) + min
+		tc := rand.Intn(maxc-minc+1) + minc
 		if tc == 0 {
 			return 0, 0
 		}
@@ -59,7 +59,7 @@ func makeCoverageGenFn(min, max int) func() (total, covered int64) {
 			total := int64(float64(100*covered) / float64(tc))
 
 			cp := coverage.CoveredPercentage(total, covered)
-			if cp >= min && cp <= max {
+			if cp >= minc && cp <= maxc {
 				return total, covered
 			}
 		}