Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regex parsing failure on windows #121

Merged
merged 9 commits into from
Nov 17, 2024
Merged

fix: regex parsing failure on windows #121

merged 9 commits into from
Nov 17, 2024

Conversation

vladopajic
Copy link
Owner

@vladopajic vladopajic commented Nov 17, 2024 •
edited
Loading

Fixes #115

Thanks to @pballok for providing solution in #118. This PR just builds on top his PR with fixes for tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2024 •
edited
Loading

go-test-coverage report:

File coverage threshold (100%) satisfied:	PASS
Total coverage threshold (100%) satisfied:	PASS
Total test coverage: 100%

@vladopajic vladopajic merged commit 4a0c753 into main Nov 17, 2024
4 of 5 checks passed
@vladopajic vladopajic deleted the fix-win-override branch November 17, 2024 14:40
@vladopajic vladopajic mentioned this pull request Nov 17, 2024
Closed
@vladopajic vladopajic changed the title fix: paths normalize for windows fix: regex parsing failure on windows Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

override regex parsing failure on Windows
1 participant
@vladopajic