Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker, fmt: fix static methods not recognized when imported from a module(fix #19127) #19133

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

shove70
Copy link
Contributor

@shove70 shove70 commented Aug 13, 2023

  1. Fix Static type methods not recognized when imported from a module #19127
  2. Add tests.
module main

import amod { SomeStruct }

fn main() {
	result := SomeStruct.new()
	println(result)
}

output:

amod.SomeStruct{}

@shove70 shove70 marked this pull request as draft August 13, 2023 14:43
@shove70 shove70 force-pushed the issue19127 branch 2 times, most recently from 54f6fcb to 56edc90 Compare August 13, 2023 15:12
@shove70 shove70 changed the title checker: fix static methods not recognized when imported from a module(fix #19127) checker, fmt: fix static methods not recognized when imported from a module(fix #19127) Aug 13, 2023
@shove70 shove70 marked this pull request as ready for review August 13, 2023 17:17
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@shove70 shove70 force-pushed the issue19127 branch 2 times, most recently from 0fe264c to 4aad81a Compare August 14, 2023 00:52
@spytheman spytheman merged commit 58d4bd6 into vlang:master Aug 14, 2023
48 checks passed
@shove70 shove70 deleted the issue19127 branch August 14, 2023 03:31
Wertzui123 pushed a commit to Wertzui123/v that referenced this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static type methods not recognized when imported from a module
2 participants