Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: fix typeof of typeof.name #19323

Merged
merged 1 commit into from
Sep 10, 2023

fix

e99fe26
Select commit
Loading
Failed to load commit list.
Merged

checker: fix typeof of typeof.name #19323

fix
e99fe26
Select commit
Loading
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded Sep 10, 2023 in 14s

Analysis complete

Summary

This pull request fixes a compiler bug with selector expressions and adds a test case for the typeof builtin function. It modifies vlib/v/gen/c/comptime.v and vlib/v/tests/typeof_name_test.v.

Walkthrough

  • Fix compiler crash for invalid selector expression type (link)

  • Add test case for typeof builtin function (link)

    Poem

    typeof tested

Compiler bug is fixed now
Autumn leaves no trace

Emoji

🐛✅🆕

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 11 seconds
vlib/v/gen/c/comptime.v ✅ Finished 4.9 seconds
vlib/v/tests/typeof_name_test.v ✅ Finished 4.9 seconds