vcreate: test new module creation #19519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
force-pushed
the
vcreate/test-new-module-creation
branch
7 times, most recently
from
7caca5f
to
0f4f951
Compare
ttytm
force-pushed
the
vcreate/test-new-module-creation
branch
from
daa8011
to
ff4ba60
Compare
ttytm
force-pushed
the
vcreate/test-new-module-creation
branch
from
16bdbbd
to
e72a962
Compare
spytheman
reviewed
Oct 9, 2023
| set project_name [lindex $argv 1] | ||
| set model [lindex $argv 2] | ||
|
|
||
| spawn $v_root/v run $v_root/cmd/tools/vcreate/ new $project_name $model |
There was a problem hiding this comment.
Suggested change
| spawn $v_root/v run $v_root/cmd/tools/vcreate/ new $project_name $model | |
| spawn $v_root/v new $project_name $model |
There was a problem hiding this comment.
This will be closer to what the final user will type/run . V should take care of compiling its cmd/tools/vcreate and then run it by itself.
There was a problem hiding this comment.
That's certainly closer to the actual usage.
It seems that using v new for the compiled v executable doesn't want to work yet on mac. Mac wasn't failing when running vcreate.v directly.
Co-authored-by: Delyan Angelov <delian66@gmail.com>
spytheman
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 6b25370
This pull request adds a test function and a script for the
vcreatetool. The test function uses theexpecttool and thev.vmodmodule to check the interactive input and output of thev createcommand. The scriptnew_no_arg.expectsimulates the user input for creating a new project.🤖 Generated by Copilot at 6b25370
new_no_arg.expectto test the interactive input of thev createcommand (F0)v.vmodmodule invcreate_test.vto use its functions for decoding thev.modfile (link)test_inputinvcreate_test.vthat uses thenew_no_arg.expectscript to create and verify a project with given input values (link)