parser: deprecate old attribute syntax & update remaining (missed) attributes #19879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-conigliaro
changed the title
joe-conigliaro
force-pushed
the
attr_syntax_old_deprecate
branch
from
f12abe9
to
028678c
Compare
spytheman
reviewed
Nov 15, 2023
spytheman
reviewed
Nov 15, 2023
Neither. It will be best for it to be a notice for say a week, then a warning for another week, and then an error, so that people can have time to upgrade. |
Co-authored-by: Delyan Angelov <delian66@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a deprecation warning for the old attribute syntax. After a decided upon amount of time, support for the old syntax will then be completely removed.
Should this deprecation be a warning or an error? It would be nice to push for all code to be migrated, and the old syntax removed as soon as possible.
🤖 Generated by Copilot at f12abe9
Warn users about deprecated attribute syntax with square brackets in
vlib/v/parser/parser.v. Suggest using the new syntax with at-signs instead.🤖 Generated by Copilot at f12abe9