datatypes: make Direction pub and fix and add tests for push_many
#19983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Nov 24, 2023
|
The CI failure is unrelated, and I could not reproduce it locally 🤔 . Good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on PR #19975
🤖[deprecated] Generated by Copilot at 9972274
This pull request enhances the
datatypesmodule by exposing theDirectionenum and fixing thepush_manymethod forDoublyLinkedList. It also adds a new test case to verify the fix.🤖[deprecated] Generated by Copilot at 9972274
Directionenum public to allow other modules to use it (link)push_manymethod to reverse elements when pushing to the front of the list (link)push_manymethod with both directions indoubly_linked_list_test.v(link)