Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: disallow indexing mut struct, when using as parameters #19992

Merged
merged 1 commit into from
Nov 27, 2023
Merged

checker: disallow indexing mut struct, when using as parameters #19992

merged 1 commit into from
Nov 27, 2023

Conversation

shove70
Copy link
Contributor

@shove70 shove70 commented Nov 25, 2023 •
edited
Loading

  1. make an error for indexing the mut struct
  2. Add tests.

Currently, zz &MyStruct and zz[0] V give a warning:

warning: pointer indexing is only allowed in `unsafe` blocks

but mut zz MyStruct and zz[0] do not

@shove70 shove70 mentioned this pull request Nov 25, 2023
Merged
@shove70 shove70 force-pushed the struct_index branch 2 times, most recently from ab234db to 2e4e4d7 Compare November 26, 2023 04:50
@Delta456
Copy link
Member

Is this PR co-related to #19949?

@spytheman
Copy link
Member

Is this PR co-related to #19949?

afaik no

@shove70 shove70 changed the title checker: add an unsafe block required notice when indexing the mut struct checker: disallow indexing mut struct, when using as parameters Nov 26, 2023
@shove70
Copy link
Contributor Author

shove70 commented Nov 27, 2023

afaik no

yep, almost no :)

@spytheman spytheman merged commit b9a7de5 into vlang:master Nov 27, 2023
54 checks passed
@shove70 shove70 deleted the struct_index branch November 27, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shove70 @Delta456 @spytheman