Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlib: add compress/szip module #20003

Merged
merged 4 commits into from
Nov 27, 2023
Merged

vlib: add compress/szip module #20003

merged 4 commits into from
Nov 27, 2023

Conversation

StunxFS
Copy link
Contributor

@StunxFS StunxFS commented Nov 26, 2023

This PR adds the compress/zip module, and deprecates the szip module.

@StunxFS StunxFS marked this pull request as ready for review November 27, 2023 00:00
@JalonSolov
Copy link
Contributor

Hmm... I think I'd prefer this as compress/szip... so basically just moving the files, rather than renaming them.

If V ever gets a zip module that is the archive format, it should have the zip name, not a gzip type compression module.

@StunxFS
Copy link
Contributor Author

StunxFS commented Nov 27, 2023

@JalonSolov Ok, it seems logical to me. I have changed the module name to szip.

@StunxFS StunxFS changed the title vlib: add compress/zip module vlib: add compress/szip module Nov 27, 2023
@spytheman
Copy link
Member

I fail to see the difference?

vlib/szip can read/write .zip files, not sure if all of them, but enough to be able to open .apk or Excel .xlsx ones, and those are also using the PKZip container format described here https://users.cs.jmu.edu/buchhofp/forensics/formats/pkzip.html .

@spytheman spytheman merged commit 6084dcd into vlang:master Nov 27, 2023
42 checks passed
@StunxFS StunxFS deleted the move_szip branch November 27, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants