-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json2 perf: encode faster than cJSON #20052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Dec 5, 2023
spytheman
requested changes
Dec 5, 2023
enghitalo
changed the title
json2 perf: encode as faster as cJSON
json2 perf: encode faster than cJSON
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
reviewed
Dec 28, 2023
spytheman
removed
the
Needs Rebase
The code of the PR must be rebased over current master before it can be approved.
label
Dec 29, 2023
spytheman
approved these changes
Dec 29, 2023
Excellent work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json2 became 2x or 3x faster in -prod. In some cases, more faster than cJSON.
Even after array_push_many fix PR
Before / Now
MAX_ITERATIONS=100_000 ./v -prod crun vlib/v/tests/bench/bench_json_vs_json2.v
🤖[deprecated] Generated by Copilot at d32ffe3
Refactor the JSON encoder in
vlib/x/json2
to use byte buffers and unsafe operations for faster and more efficient encoding. Extract the encoder code to a separate fileencoder.v
.🤖[deprecated] Generated by Copilot at d32ffe3
io
andstrings
modules fromvlib/x/json2/encoder.v
(link)[]u8
) instead of writers (io.Writer
) as arguments, to improve performance and memory efficiency by using pre-allocated buffers instead of writers that may allocate memory on each write operation (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)str()
method for booleans, to avoid memory allocation (link, link, link, link, link, link, link)strings
module fromvlib/x/json2/json2.v
(link)json_str
andencode_array
methods to use byte buffers instead of string builders, and to free buffers instead of builders, for the same reasons as above (link, link)vlib/x/json2/json2.v
tovlib/x/json2/encoder.v
to reflect the refactoring of the encoder module (link, link)