cgen, checker: fix comptime map type resolution on generic arg #20097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Dec 7, 2023
| @@ -4631,7 +4631,7 @@ fn (mut g Gen) cast_expr(node ast.CastExpr) { | |||
| && (sym.info as ast.Alias).parent_type !in [expr_type, ast.string_type]) { | |||
| if sym.kind == .string && !node.typ.is_ptr() { | |||
| cast_label = '*(string*)&' | |||
| } else { | |||
| } else if !(g.is_cc_msvc && g.typ(node.typ) == g.typ(expr_type)) { | |||
There was a problem hiding this comment.
It is unfortunate, that this msvc specific thing is needed :-| .
There was a problem hiding this comment.
I do not have a good alternative though.
There was a problem hiding this comment.
It is unfortunate, that this msvc specific thing is needed :-| .
Yes, so bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20089
🤖[deprecated] Generated by Copilot at 531969f
This pull request adds support for comptime map arguments in generic functions. It modifies the
vlib/v/checker/fn.vandvlib/v/gen/c/fn.vfiles to handle map types in the checker and gen modules.🤖[deprecated] Generated by Copilot at 531969f