Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlib: use builtin flush functions #20108

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Dec 6, 2023

🤖[deprecated] Generated by Copilot at 0d8289f

Refactored some builtin and os functions to use flush_stdout and flush_stderr from vlib/builtin/builtin.c.v. This improves code consistency and maintainability across different modules and platforms.

🤖[deprecated] Generated by Copilot at 0d8289f

  • Refactor the code to use flush_stdout and flush_stderr functions from vlib/builtin/builtin.c.v instead of calling C functions directly (link, link, link, link, link, link)
  • Move the code for printing to standard output and error from vlib/os/os.c.v to vlib/builtin/builtin.c.v as part of a larger restructuring of the os module (link)

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I had that in my TODO list for several weeks :-| .

@spytheman spytheman merged commit 5b74f3a into vlang:master Dec 7, 2023
55 checks passed
@ttytm ttytm deleted the vlib/use-builtin-flush-fns branch December 15, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants