Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net.http: remove read_set_cookies function #20187

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Dec 15, 2023

🤖[deprecated] Generated by Copilot at 70d10d2

Removed read_set_cookies function and updated tests for cookie parsing. The changes improve the performance and correctness of the vlib/net/http/cookie.v module and align it with RFC 6265.

🤖[deprecated] Generated by Copilot at 70d10d2

  • Remove read_set_cookies function from cookie.v as it is redundant with parse_set_cookie (link)
  • Update test cases in cookie_test.v to use parse_set_cookie instead of read_set_cookies (link)
  • Remove test function for read_set_cookies from cookie_test.v and replace it with a new test function for parse_set_cookie (link)

This PR removes the read_set_cookies function because it is misleading and not used anywhere else

@Delta456 Delta456 marked this pull request as draft December 15, 2023 13:28
@Delta456 Delta456 marked this pull request as ready for review December 15, 2023 13:45
@spytheman spytheman merged commit 6e47782 into vlang:master Dec 15, 2023
42 of 43 checks passed
@Delta456 Delta456 deleted the cookie_rm_write_set_method branch December 15, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants