Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make public map_from in json2 #20294

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Make public map_from in json2 #20294

merged 4 commits into from
Dec 29, 2023

Conversation

esquerbatua
Copy link
Contributor

module x.json2

It's useful to make public as map function to transform any structure to modify data in the fly and transform the map into json directly

@spytheman
Copy link
Member

The CI failure is for vlib/x/json2/json2.v:432:0:pub fn map_from[T](t T) map[string]Any , since it is now public, it needs to be documented.
Please add a short comment above it, starting with: // map_from to fix it.

Copy link
Contributor Author

@esquerbatua esquerbatua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docs to map_from

@spytheman spytheman merged commit db80a00 into vlang:master Dec 29, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants