Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: fix Process struct fields documentation applied to wrong field #21023

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

bramvbilsen
Copy link
Contributor

The fields of the Process struct in the os modules incorrectly have their documentation behind the field, instead of before. Example of what it currently looks like:

pub struct Process {
pub mut:
        // ...
	pid      int    // the PID of the process
	code     int = -1
	// the exit code of the process, != -1 *only* when status is .exited *and* the process was not aborted
	// ...
}

This results in code incorrectly having the documentation associated with pid. This specific case is confusing in particular as both are integers and code could be mistaken for the pid after reading the associated comments.

vlib/os/process.v Outdated Show resolved Hide resolved
@spytheman spytheman merged commit eaa4edf into vlang:master Mar 15, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants