Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: disallow iterating through .params if not a function #22428

Merged
merged 5 commits into from
Oct 7, 2024
Merged

checker: disallow iterating through .params if not a function #22428

merged 5 commits into from
Oct 7, 2024

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Oct 6, 2024

Fixes #22411

spytheman
spytheman reviewed Oct 7, 2024
View reviewed changes
vlib/v/checker/comptime.v Outdated Show resolved Hide resolved
spytheman
spytheman approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit f4c0484 into vlang:master Oct 7, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medvednikov medvednikov medvednikov left review comments

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compile time reflection crash when using .params
3 participants
@Delta456 @spytheman @medvednikov