Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math.big: improve the performance of left_shift_digits_in_place and right_shift_digits_in_place #22450

Merged
merged 1 commit into from
Oct 8, 2024
Merged

math.big: improve the performance of left_shift_digits_in_place and right_shift_digits_in_place #22450

merged 1 commit into from
Oct 8, 2024

Conversation

kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Oct 8, 2024

This PR will improve left_shift_digits_in_place and right_shift_digits_in_place performance.

Before:

        134752       4252.705ms          31559ns math__big__left_shift_digits_in_place

After:

        134752         31.996ms            237ns math__big__left_shift_digits_in_place

spytheman
spytheman approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman changed the title math.big: performance improve for shift math.big: performance improvement for left_shift_digits_in_place and right_shift_digits_in_place Oct 8, 2024
@spytheman spytheman changed the title math.big: performance improvement for left_shift_digits_in_place and right_shift_digits_in_place math.big: improve the performance of left_shift_digits_in_place and right_shift_digits_in_place Oct 8, 2024
@spytheman spytheman merged commit 0224581 into vlang:master Oct 8, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbkpbot @spytheman