Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picoev: fix wrong return on failure #22463

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Oct 9, 2024

Fix #22292

Just noticed running examples/veb/veb_assets/vweb_assets.v

Huly®: V_0.6-20922

@felipensp felipensp marked this pull request as ready for review October 9, 2024 11:59
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find.
Would not just listening_socket_fd := listen(config)! work, or is the error hidden otherwise?

@spytheman spytheman merged commit 98f66d8 into vlang:master Oct 9, 2024
67 checks passed
@esquerbatua
Copy link
Contributor

Good find. Would not just listening_socket_fd := listen(config)! work, or is the error hidden otherwise?

The error should happens also, because it's from the picoev spawned thread, when makes the first event loop without the socket created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a port is unavailable, veb segfaults
3 participants