Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: reduce sym resolution calls on infix checking #22476

Merged
merged 1 commit into from
Oct 10, 2024
Merged

checker: reduce sym resolution calls on infix checking #22476

merged 1 commit into from
Oct 10, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Oct 10, 2024 •
edited by huly-for-github bot
Loading

Cleanup infix expr.

Huly®: V_0.6-20934

spytheman
spytheman approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That refactoring seems a bit bold to me, since left_sym and right_sym do change between the checks, but I hope that we do already have enough tests to catch the potential regressions.

Excellent work.

@spytheman spytheman marked this pull request as ready for review October 10, 2024 17:48
@spytheman spytheman merged commit 1a145bf into vlang:master Oct 10, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipensp @spytheman