all: support extra commands, vab <cmd> where <cmd> comes from vab install extra user/vab-<cmd>
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`vab-xyz` command
all: rename module `user` -> `extra`
larpon
changed the title
vab <cmd> where <cmd> comes from vab install user/vab-<cmd>vab <cmd> where <cmd> comes from vab install extra user/vab-<cmd>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding "extra commands" to
vab.The feature only work if
vabis explicitly compiled with support for it tomake sure no arbitrary extra commands are executed by
vabper default.A working example:
Compile
vabwith extra command support (needs this PR checked out):v -d vab_allow_extra_commands ~/.vmodules/vabInstall an extra command (
larpon/vab-sdlsupports building SDL based V apps for android):vab install extra larpon/vab-sdl vab doctor # Should show a section with installed extra commands where `vab-sdl` should show.Using the extra command (needs
vlang/sdlmodule installed):vab sdl ~/.vmodules/sdl/examples/tvintris -o /tmp/tvintris.apkTransfer
/tmp/tvintris.apkto your device and run it to see the game in action(NOTE sound does not work because of a limitation of the version of SDL_mixer's mod support on Android).
Feedback and ideas are welcome.
If this goes in I'm planing on writing a section for the documentation about best practices and
conventions when developing these extra commands.