Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 250 #282

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Fixes 250 #282

merged 3 commits into from
Aug 27, 2021

Conversation

pouyakary
Copy link
Collaborator

@pouyakary
Copy link
Collaborator Author

Should I merge myself?

@serkonda7
Copy link

serkonda7 commented Aug 26, 2021 •
edited
Loading

This still requires a test.
Should I create one or want you?

@pouyakary
Copy link
Collaborator Author

Ah sorry I had forgotten that :/ - shall do

@pouyakary
Copy link
Collaborator Author

pouyakary commented Aug 26, 2021 •
edited
Loading

@serkonda7 So can I push the merge button?

@serkonda7
Copy link

Thanks for your work 👍

@serkonda7 serkonda7 merged commit d238055 into master Aug 27, 2021
@serkonda7 serkonda7 deleted the pouya/add-comma branch September 8, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pouyakary @serkonda7