Add option to compare site_id when values are equal to determine ultimate winner #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromegn
force-pushed
the
site-id-tie-break-eq-values
branch
from
07bdb38
to
3a01980
Compare
tantaman
reviewed
Dec 26, 2023
| @@ -1,2 +1,2 @@ | |||
| // The sha of the commit that this version of crsqlite was built from. | |||
| pub const SHA: &'static str = ""; | |||
| pub const SHA: &'static str = "3a01980562615001d765eec61e3ed58147a93f93"; | |||
There was a problem hiding this comment.
hm, I guess I should ignore this file and only generate it at build time?
There was a problem hiding this comment.
Oh, possibly yes. I didn't notice it.
| return 0; | ||
| } | ||
| } else { | ||
| // unhandled config setting |
There was a problem hiding this comment.
I wasn't quite sure which way to go there. I didn't want to be too strict for the list of supported config settings, but I did want to be strict for each setting's value type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 functions
crsql_config_set(name, value)andcrsql_config_get(name). They enable setting and getting config settings persisted to the database, but also available incrsql_ExtData.The first and only setting right now is
merge-equal-valuesmaking sure there's always a winner by tie-breaking onsite_idwhen everything else is equal.