Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp the docker image #181

Merged
merged 2 commits into from
May 7, 2021
Merged

Revamp the docker image #181

merged 2 commits into from
May 7, 2021

Conversation

jakzal
Copy link
Member

@jakzal jakzal commented May 7, 2021

Base the docker image on alpine directly

Currently, we use an outdated version of java 8.

From the OpenJDK team:

The OpenJDK port for Alpine is not in a supported release by OpenJDK, since it is not in the mainline code base. It is only available as early access builds of OpenJDK Project Portola. See also this comment. So this image follows what is available from the OpenJDK project's maintainers.

What this means is that Alpine based images are only released for early access release versions of OpenJDK. Once a particular release becomes a "General-Availability" release, the Alpine version is dropped from the "Supported Tags"; they are still available to pull, but will no longer be updated.

Implement multi-arch builds

  • amd64
  • arm64 (Apple M1)

From the OpenJDK team:

> The OpenJDK port for Alpine is not in a supported release by OpenJDK, since it is not in the mainline code base. It is only available as early access builds of OpenJDK Project Portola. See also [this comment](docker-library/openjdk#235 (comment)). So this image follows what is available from the OpenJDK project's maintainers.
>
> What this means is that Alpine based images are only released for early access release versions of OpenJDK. Once a particular release becomes a "General-Availability" release, the Alpine version is dropped from the "Supported Tags"; they are still available to pull, but will no longer be updated.

Signed-off-by: Jakub Zalas <jakub@zalas.pl>
@jakzal jakzal force-pushed the feature/docker-multi-arch-builds branch from c865bc8 to 3145723 Compare May 7, 2021 18:33
Signed-off-by: Jakub Zalas <jakub@zalas.pl>
@jakzal jakzal marked this pull request as ready for review May 7, 2021 18:41
@jakzal jakzal merged commit 7059982 into master May 7, 2021
@jakzal jakzal deleted the feature/docker-multi-arch-builds branch May 7, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant