Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMake build system #17

Closed
wants to merge 17 commits into from
Closed

Add CMake build system #17

wants to merge 17 commits into from

Conversation

ProExpertProg
Copy link

@ProExpertProg ProExpertProg commented Aug 23, 2024 •
edited
Loading

Added a CMake-based build system to enable building this package from source in the vLLM build. That will allow using PyTorch nightly, which is needed by the torch.compile and another project in vLLM.

Heavily inspired by the new build system in vLLM.

bnellnm
bnellnm reviewed Aug 23, 2024
View reviewed changes
setup.py Show resolved Hide resolved
bnellnm
bnellnm reviewed Aug 23, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
bnellnm
bnellnm reviewed Aug 23, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
bnellnm
bnellnm reviewed Aug 23, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
bnellnm
bnellnm reviewed Aug 23, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@ProExpertProg ProExpertProg marked this pull request as ready for review August 26, 2024 15:20
@ProExpertProg ProExpertProg mentioned this pull request Sep 4, 2024
Merged
bnellnm
bnellnm approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@bnellnm bnellnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor comment in the test file.

bnellnm
bnellnm requested changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@bnellnm bnellnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed the python finding code first time.

@ProExpertProg ProExpertProg marked this pull request as draft September 10, 2024 21:07
@ProExpertProg
Copy link
Author

(marking as draft until I resolve the binary size/arch explosion)

@ProExpertProg
Copy link
Author

Closed in favor of #19

@ProExpertProg ProExpertProg deleted the luka/cmake branch September 20, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnellnm bnellnm bnellnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ProExpertProg @bnellnm