-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loguru logging standardization for LLM Compressor #11
Conversation
…tion overrides for library imports
81a14e1
to
28c35b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is loguru a lightweight dep?
I ask because vLLM does all their logging through the native python library, so I think it would be nice to match up: https://github.com/vllm-project/vllm/blob/b90d8cd832669b9ad7c48cd9a431e80836778b56/vllm/logger.py
However if there is engineering value in a new logging library I can see the value, especially since it seems to preserve the same interface for creating new logs.
@markurtz Got the tests in a passing state. Ran some manual tests of oneshot and reloading, the logs look good in both. Just had a few notes for you above |
Enable logging across LLM compressor and enable environment configuration overrides for library imports
SUMMARY:
TEST PLAN:
Automation tests added, needs further manual testing for verfiication