Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Function Names for Logging #12

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Clarify Function Names for Logging #12

merged 1 commit into from
Jul 2, 2024

Conversation

Satrat
Copy link
Contributor

@Satrat Satrat commented Jul 2, 2024

SUMMARY:

  • Each module compressor(sparseGPT, WANDA, GPTQ) implemented a fasterprune method, but this is misleading for GPTQ which does quantization only. Renaming fasterprune->compress
  • Rename LayerCompressor.prune() to LayerCompressor.compress_module() for the same reason

TEST PLAN:
Manually tested a w4a16 quantization example to confirm the logging change:

Before

2024-07-02T14:15:00.233030+0000 | prune | INFO - Compressing model.layers.11.self_attn.q_proj.model.layers.11.self_attn.q_proj...
2024-07-02T14:15:01.061103+0000 | fasterprune | INFO - time 0.83
2024-07-02T14:15:01.061573+0000 | fasterprune | INFO - error 6155.81

After

2024-07-02T14:31:16.224969+0000 | compress_module | INFO - Compressing model.layers.20.model.layers.20.self_attn.q_proj...
2024-07-02T14:31:17.100250+0000 | compress | INFO - time 0.87
2024-07-02T14:31:17.100596+0000 | compress | INFO - error 4623.34

@Satrat Satrat merged commit 39cbf17 into main Jul 2, 2024
8 of 12 checks passed
markmc pushed a commit to markmc/llm-compressor that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants